Skip to content

London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | Chat App frontend and backend#75

Open
ebrahimbeiati wants to merge 1 commit into
CodeYourFuture:mainfrom
ebrahimbeiati:main
Open

London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | Chat App frontend and backend#75
ebrahimbeiati wants to merge 1 commit into
CodeYourFuture:mainfrom
ebrahimbeiati:main

Conversation

@ebrahimbeiati
Copy link
Copy Markdown

@ebrahimbeiati ebrahimbeiati commented Mar 27, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Backend
https://xwc7hmpmk5kvt9ktptcvuuke.hosting.codeyourfuture.io

Frontend
https://uretqju43s9008b1nyjk586m.hosting.codeyourfuture.io

Description

Additional Feature
Auto‑scroll: The chat automatically scrolls to the newest message when messages load.

@github-actions

This comment has been minimized.

Sign in to view
@ebrahimbeiati ebrahimbeiati changed the title London | 26‑SDC‑Mar | Ebrahim Beiati‑Asl | Decomposition | Sprint 2 | Chat App (Frontend + Backend Deployment) London | 26‑SDC‑Mar | Ebrahim Beiati‑Asl | Decomposition | Sprint 2 | Chat App Frontend and Backend Deployment Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@ebrahimbeiati ebrahimbeiati changed the title London | 26‑SDC‑Mar | Ebrahim Beiati‑Asl | Decomposition | Sprint 2 | Chat App Frontend and Backend Deployment London | 26-SDC-Mar | Ebrahim Beiati-Asl | Decomposition | Sprint 2 | Chat App Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@ebrahimbeiati ebrahimbeiati changed the title London | 26-SDC-Mar | Ebrahim Beiati-Asl | Decomposition | Sprint 2 | Chat App London | 26-SDC-Mar | Ebrahim Beiati-Asl | Decomposition | Sprint 2 | Chat App Frontend and Backend Deployment Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@ebrahimbeiati ebrahimbeiati changed the title London | 26-SDC-Mar | Ebrahim Beiati-Asl | Decomposition | Sprint 2 | Chat App Frontend and Backend Deployment London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | Chat App Frontend and Backend Deployment Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@ebrahimbeiati ebrahimbeiati changed the title London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | Chat App Frontend and Backend Deployment London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | Chat App Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@ebrahimbeiati ebrahimbeiati changed the title London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | Chat App London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | Chat App frontend and backend Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 27, 2026
@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 28, 2026
cjyuan
cjyuan reviewed May 24, 2026
View reviewed changes
Copy link
Copy Markdown

@cjyuan cjyuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works on normal circumstances. My comments are mainly surrounding handling of
errors and unusual user input.

The README has this requirement:

It must also support at least one additional feature.

Can you describe the additional features you have implemented?

Comment thread chat-app/frontend/script.js Outdated
Comment thread chat-app/frontend/script.js Outdated
Comment thread chat-app/backend/server.js
app.post("/messages", (req, res) => {
const message = req.body;
messages.push(message);
res.status(201).json(message);
Copy link
Copy Markdown

@cjyuan cjyuan May 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason to embed the received user message in the response?

Note: Normally we should also validate the message, but in this exercise let's assume the message format is always valid. That is, let's assume the received message is always sent by the code in script.js.

Copy link
Copy Markdown
Author

@ebrahimbeiati ebrahimbeiati May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I return the created message because the server adds the timestamp, so sending it back lets the client know the final version on the server. But in this exercise the frontend doesn’t use the POST response anyway, since it reloads all messages after sending, so returning it isn’t strictly necessary.

Comment thread chat-app/frontend/script.js Outdated
Comment thread chat-app/frontend/script.js Outdated
Comment thread chat-app/frontend/script.js Outdated
Comment thread chat-app/frontend/script.js Outdated
Comment thread chat-app/frontend/script.js
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 24, 2026
@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 24, 2026
@cjyuan
Copy link
Copy Markdown

cjyuan commented May 25, 2026

Changes look good.

There is still an unanswered question (in the comment which I haven't marked as resolved), and an unaddressed issue related to describing the extra features in the PR description.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@cjyuan
Copy link
Copy Markdown

cjyuan commented May 25, 2026 •
edited
Loading

image image

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@ebrahimbeiati
Copy link
Copy Markdown
Author

ebrahimbeiati commented May 25, 2026

I added auto‑scroll so the chat always jumps to the newest message when messages load.
Screenshot 2026-05-25 at 1 10 21 PM

@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@cjyuan
Copy link
Copy Markdown

cjyuan commented May 25, 2026 •
edited
Loading

The spec says

It must also support at least one additional feature.

Can you think of a place to share that info so that people interested in your implementation can easily find out what extra features you have implemented?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 25, 2026

There are too many files committed in this pull request.

Please check and make sure you have not accidentally committed a cache, virtual environment, or npm package directory.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 25, 2026

There are too many files committed in this pull request.

Please check and make sure you have not accidentally committed a cache, virtual environment, or npm package directory.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@ebrahimbeiati ebrahimbeiati added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 25, 2026

There are too many files committed in this pull request.

Please check and make sure you have not accidentally committed a cache, virtual environment, or npm package directory.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@cjyuan
Copy link
Copy Markdown

cjyuan commented May 25, 2026

Commit 52f1240 introduced 1000+ files to this PR.

image

Can you fix it? I will mark this PR as Complete first.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 25, 2026

There are too many files committed in this pull request.

Please check and make sure you have not accidentally committed a cache, virtual environment, or npm package directory.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 25, 2026

There are too many files committed in this pull request.

Please check and make sure you have not accidentally committed a cache, virtual environment, or npm package directory.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Decomposition The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ebrahimbeiati @cjyuan